[Bug 517859] Review Request: vmpsd - vmpsd is a GPL implementation of Cisco Systems' VMPS

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517859


Stjepan Gros <stjepan.gros at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |stjepan.gros at gmail.com




--- Comment #1 from Stjepan Gros <stjepan.gros at gmail.com>  2009-08-18 16:53:28 EDT ---
I looked a bit on your package and I have few comments/questions. You are
generating init scripts in spec file. Isn't it better to distribute them along
with source?

Furhtermore, I believe you should add %preun section to spec file that will try
to stop the service before uninstaling it.

There is an error reported by rpmlint when run on the binary package:

$ rpmlint vmpsd-1.4.01-1.fc11.x86_64.rpm 
vmpsd.x86_64: W: summary-not-capitalized vmpsd is a GPL implementation of Cisco
Systems' VMPS
vmpsd.x86_64: W: name-repeated-in-summary vmpsd
vmpsd.x86_64: E: init-script-without-chkconfig-postin /etc/rc.d/init.d/vmpsd
vmpsd.x86_64: W: service-default-enabled /etc/rc.d/init.d/vmpsd
1 packages and 0 specfiles checked; 1 errors, 3 warnings.


Trying to build package in mock was successful.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.