[Bug 507849] Review Request: anjal - email client for small screen devices

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507849


D. Marlin <dmarlin at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dmarlin at redhat.com




--- Comment #6 from D. Marlin <dmarlin at redhat.com>  2009-08-18 17:42:53 EDT ---

- I believe configure will be run twice, once in the prep stage (through
autogen.sh) and once in the build stage.

The following autogen.sh command line should avoid this:

  # run autogen.sh until we have a proper release, but don't run configure
twice.
  NOCONFIGURE=yes ./autogen.sh


- I think the spec file should be using desktop-file-install instead of just
validating the .desktop file.

-desktop-file-validate %{buildroot}%{_datadir}/applications/%{name}.desktop
+desktop-file-install \
+        --dir=%{buildroot}%{_datadir}/applications \
+        %{buildroot}%{_datadir}/applications/%{name}.desktop


- rpmlint complains:

anjal.i686: W: incoherent-version-in-changelog 0.1.0-0.3
['0.1.0-0.3.20090811git813fc0f.fc12', '0.1.0-0.3.20090811git813fc0f']

It seems to be confused by the "snapshot tag" in the release.  Perhaps modify
the %changelog entry to match?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.