[Bug 516782] Review Request: libcpuset - Processor and memory placement library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516782


Stepan Kasal <skasal at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |skasal at redhat.com




--- Comment #7 from Stepan Kasal <skasal at redhat.com>  2009-08-20 07:56:58 EDT ---
Hello,

(In reply to comment #4)
> %configure --disable-static --disable-dependency-tracking
> CFLAGS="$RPM_OPT_FLAGS"
> make %{?_smp_mflags}
[...]
> 2. %configure already contain CFLAGS. The explicit CFLAGS= is superflous.  

... and misplaced; CFLAGS should be set *before* configure is called.

(In reply to comment #6)
> Yes, upstream doesn't package their package properly but ships a [..]
> package, which doesn't comply to the autotools' working principles.

Correct.  Jan, please report that upstream.

> If you want deterministic builts, you're better off running the autotools in
> advance to building, generate patches and apply them during builds.

... and make sure that the timestamps of all the autotools generated files (no 
matter whether they chnaged or not) are in the correct order.
Otherwise, the autotools rebuild rules are triggered.  They do nothing in
autotools-free buildroot, but do the rebuild otherwise; that can be confusing.

But getting the timestamps right is often quite tricky.

That's why I recommend calling autoreconf if the changes to autoconfigury are
bigger.  I would recommend it in this case as well.

Moreover, the rule "do not run autotools" evolved in times when autotools were
much less stable than these days, so the risk that things will break with an
update was higher.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.