[Bug 502130] Review Request: openocd - Open On-Chip Debugger

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502130





--- Comment #11 from Chitlesh GOORAH <chitlesh at gmail.com>  2009-08-20 09:07:56 EDT ---
#001 : ScriptletSnippets - Texinfo

Please turn the spec file with respect to the Fedora packaging guidelines as
stated on 

http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Texinfo

#002 : %prep instead of %build

Move the following to the %prep section

-------------
cd doc
iconv -f iso8859-1 -t utf-8 openocd.info > openocd.info.conv
mv -f openocd.info.conv openocd.info
-------------

#003 : Improve future commit patches and logs

Use the following style for the %configure :

%configure \
    --disable-werror \
    --disable-static \
    --enable-shared \
    --enable-parport \
    --enable-parport_ppdev \
    --enable-ft2232_libftdi 
    --enable-ep93xx \
    --enable-at91rm9200 \
    --enable-usbprog \
    --enable-presto_libftdi \
    --enable-jlink \
    --enable-vsllink \
    --enable-rlink \
    --enable-dummy \
    --enable-gw16012 \
    --enable-amtjtagaccel \
    --enable-arm-jtag-ew

This is because, when openocd will be approved and everytime you will update
it, you will have to commit the srpm to fedora cvs repositories. For each
commit, a log message (a patch-like message) will automatically be sent to the
fedora-cvs-commits mailing list, hence it would be nice that the updated item
can be easily spotted in the logs.

#004: Build requires:

libftdi-devel already requires libusb-devel see

$ rpm -qR libftdi-devel

Remove libusb-devel from the buildrequires

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.