[Bug 513896] Review Request: pcp - performance monitoring and collection service

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513896





--- Comment #16 from Jarod Wilson <jwilson at redhat.com>  2009-08-20 11:27:51 EDT ---
Okay, there's still some slightly alarming rpmlint spew... I understand the
header files need to be in the main package, but what about all these c files?
Particularly the ones under 'sample' and 'demo' sub-directories. These should
go into somewhere like /usr/share/doc/pcp/{sample,demo}/, not into
/usr/share/pcp or /var/lib/pcp.

The .NeedRebuild touch and rm in the scriptlets is also... Not pretty. Files
created by an rpm need to be owned by the rpm, even if they're temporary files.
You could add an empty file to the rpm %files list itself, so the rpm lays it
down and owns it, and there's technically no harm in the file being deleted
from the system after this rebuild takes place. If the file continues to exist,
an rpm -e will remove it, no need for the rm in the %postun scriptlet.

Speaking of the scriptlets... Standard convention is to put them before the
%files lists, not after. %files is generally the last thing before the
%changelog.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.