[Bug 226159] Merge Review: mozplugger

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226159





--- Comment #8 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-08-21 06:01:38 EDT ---
BuildPreReqs are not used, use BuildRequires instead. But I see you had already
changed that in the past 5 months, so that's OK.

**

The patches don't have comments, please add them.

**

The Obsoletes: plugger can probably be removed, since this package is 6 years
old and we only support upgrades from F(N-1) -> F(N). That takes care of

mozplugger.src:18: W: unversioned-explicit-obsoletes plugger
mozplugger.x86_64: W: obsolete-not-provided plugger

**

Did you fix the permissions on the header files as well? I suggest simply using
 find . \( -name *.h -o -name *.c \) -exec chmod 644 {} \;
to get them all fixed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.