[Bug 481030] Review Request: emacs-pmd - an interface to PMD for (X)Emacs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481030





--- Comment #7 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-08-21 12:14:52 EDT ---
emacs-pmd-el.noarch: W: no-documentation
xemacs-pmd-el.noarch: W: no-documentation
5 packages and 0 specfiles checked; 0 errors, 2 warnings.

These are expected.

**

Change the %define's into %global's, unless you have a specific reason to use
%define's.

**

 %define xemacs_lispdir  %{_datadir}/xemacs/site-packages/lisp
should be
 %global xemacs_lispdir %{_datadir}/xemacs/site-packages
as per
http://fedoraproject.org/wiki/Packaging:Emacs#Template_for_a_package_for_both_GNU_Emacs_and_XEmacs

N.B. the difference in %files of the spec file template and your version
%files -n emacs-%{pkg}
%defattr(-,root,root,-)
%{emacs_lispdir}/%{pkg}/*.elc
%{emacs_startdir/*.el
%dir %{emacs_lispdir}/%{pkg}

%files -n emacs-%{pkg}-el
%defattr(-,root,root,-)
%{emacs_lispdir}/%{pkg}/*.el

"For GNU Emacs, files for add-on package foo should be placed in
/usr/share/emacs/site-lisp/foo."
"For XEmacs, files for add-on package foo should be placed in
/usr/share/xemacs/site-packages/lisp/foo."


**

As instructed by the Emacs packaging guideline, change the main package to
emacs-common-pmd and put the %doc there, no need to replicate it in emacs-pmd
and xemacs-pmd.

**

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.