[Bug 518449] Review Request: moblin-panel-people - Moblin Panel for People

bugzilla at redhat.com bugzilla at redhat.com
Fri Aug 21 23:10:47 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518449


Michel Alexandre Salim <michael.silvanus at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michael.silvanus at gmail.com
         AssignedTo|nobody at fedoraproject.org    |michael.silvanus at gmail.com
               Flag|                            |fedora-review+




--- Comment #1 from Michel Alexandre Salim <michael.silvanus at gmail.com>  2009-08-21 19:10:46 EDT ---
Everything is fine here. APPROVED.
MUST

• rpmlint: OK
• package name: OK
• spec file name: OK
• package guideline-compliant: OK
• license complies with guidelines: OK
• license field accurate: OK
• license file not deleted: OK
• spec in US English: OK
• spec legible: OK
• source matches upstream: OK (MD5 sum: df86408bf2291bbe01d9277217f68901)
• builds under >= 1 archs, others excluded: OK (Koji)
• build dependencies complete: OK (Koji)
• locales handled using %find_lang, no %{_datadir}/locale: OK
• own all directories: OK
• no dupes in %files: OK
• permission: OK
• %clean RPM_BUILD_ROOT: OK
• macros used consistently: OK
• Package contains code: OK
• clean buildroot before install: OK
• filenames UTF-8: OK

SHOULD
• package build in mock on all architectures: OK (Koji)
• package functioned as described: OK
• scriplets are sane: OK
• require package not files: OK

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list