[Bug 518447] Review Request: moblin-panel-myzone - Moblin Panel for MyZone

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518447





--- Comment #2 from Peter Robinson <pbrobinson at gmail.com>  2009-08-21 19:21:30 EDT ---

> $ rpmlint moblin-panel-myzone-0.0.1-1.fc11.src.rpm 
> moblin-panel-myzone.src: E: description-line-too-long The Moblin mutter panel
> for MyZone. MyZone allows you to see that status of friends on
> 1 packages and 0 specfiles checked; 1 errors, 0 warnings.
> 
>   Description needs Emacs M-q-ing

Fixed

> • license field accurate:
>   This is questionable. Unlike some other moblin-panel packages, the only C
> file in this package does not have a license header. Thus it cannot be possible
> to determine, per se, whether it's GPLv2 strict or v2+. From precedence, we can
> guess v2+, but could you prod upstream to add the missing header and/or write a
> clarification in README ?

I will email upstream and request clarification.

> • library -> ldconfig: MUSTFIX
> This package ships some shared libraries, so ldconfig must be called on post
> and postun

Fixed. No idea how I missed that one!

> • package functioned as described: so says Peter :)

Oh yes.... its running on rawhide on my eeePC as I type this :)

SRPM:
http://pbrobinson.fedorapeople.org/moblin-panel-myzone-0.0.1-2.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.