[Bug 518900] Review Request: desktop-effects - Switch GNOME window management and effects

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518900





--- Comment #3 from Owen Taylor <otaylor at redhat.com>  2009-08-24 07:47:48 EDT ---
(In reply to comment #2)
> Create the archive on your workstation and run scp myProject-0.1.tar.gz
> fedorahosted.org:<Project Name>. The archive will be located under
> https://fedorahosted.org/releases/

Oh, cool, I didn't know about that.

> Build fails in koji:
> http://koji.fedoraproject.org/koji/getfile?taskID=1628520&name=build.log
> Seems like you need to BR intltool

Hmm, yep. Also missing desktop-file-utils. (I started a Koji scratch build
before, but forgot to check if it finished succesfully. Built fine with those
two additions.)

> Besides this the package seems to look good.
> * No dist tag, but as it will go away in F13 (so F12 only) it is probably fine.

Just an oversight. Added.

> * You might want to update the Changelog and ship it as %doc  

I don't really like ChangeLogs for projects if there's alraeady a verbose and
readable version control log. Adding a disthook to turn git history into a
distributed ChangeLog or writing NEWS manually is definitely possible, but for
this project I'm too lazy :-)

I've now added a note to the ChangeLog in git that it intentionally isn't being
updated.

New spec and SRPM:

Spec URL: http://www.gnome.org/~otaylor/desktop-effects.spec
SRPM URL: http://www.gnome.org/~otaylor/desktop-effects-0.8.0-2.fc12.src.rpm

Thanks for the review!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.