[Bug 517851] Review Request: beacon - WYSIWYG editor for docbook xml

bugzilla at redhat.com bugzilla at redhat.com
Mon Aug 24 12:13:18 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517851





--- Comment #7 from Lubomir Rintel <lkundrak at v3.sk>  2009-08-24 08:13:17 EDT ---
(In reply to comment #6)
> Updated the spec file with the changes suggested.

Thanks!

> I updated the spec file to require webserver instead of httpd but I am unsure
> if I should own /etc/httpd. Could you please explain this a bit as I seem to be
> missing something here.

If you create a directory that neither you nor none of your dependencies own,
that directory would not be removed upon package removal. That could happen in
case user would elect to use e.g. lighttpd instead of apache httpd (which would
satisfy the webserver dependency).

So you can either depend on "webserver" and own /etc/httpd, or depend directly
on "httpd" (as you did previously). It might be a better idea to just switch
back to httpd (since you use apache:apache user, etc.); sorry for the noise.

Also, please improve your %description, it seems rather short and
uninformative.

I don't think any of these are blockers, I'll approve the package once you are
sponsored. Please apply for packagers group so that you can get sponsored.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list