[Bug 519051] Review Request: maven2-plugin-shade - Maven Shade Plugin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519051


Jeff Johnston <jjohnstn at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jjohnstn at redhat.com
         AssignedTo|nobody at fedoraproject.org    |jjohnstn at redhat.com
               Flag|                            |needinfo?(overholt at redhat.c
                   |                            |om)




--- Comment #1 from Jeff Johnston <jjohnstn at redhat.com>  2009-08-24 15:25:32 EDT ---
Review Comments:

1. There is a BSD license at the top of the spec.  Should the licensing
   add "and BSD"?

2. The description for the javadoc sub-package should be:

   This package contains the API documentation for %{name}.

   The template has its group as Development/Documentation, not Documentation.

3. The Java packaging guidelines state that there should be:

   Requires: jpackage-utils

4. The following sections from the maven template of the Java
   guidelines are missing.

   %post
   %update_maven_depmap

   %postun
   %update_maven_depmap

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.