[Bug 519009] Review Request: gnome-do-docklets - Docklets for gnome-do

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519009





--- Comment #4 from Michel Alexandre Salim <michael.silvanus at gmail.com>  2009-08-24 17:24:25 EDT ---
Koji build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1630524

There are some things to fix: to sum up, spec file permission, and a directory
ownership problem that's really a gnome-do packaging bug.

MUST

• rpmlint:
gnome-do-docklets.src: W: strange-permission gnome-do-docklets.spec 0755
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

gnome-do-docklets.x86_64: E: no-binary
gnome-do-docklets.x86_64: W: only-non-binary-in-usr-lib
1 packages and 0 specfiles checked; 1 errors, 1 warnings.

spec permission needs to be fixed; the binary warnings are fine for Mono

• package name: OK
• spec file name: OK
• package guideline-compliant: OK
• license complies with guidelines: OK
• license field accurate: OK
• license file not deleted: OK
• spec in US English: OK
• spec legible: OK
• source matches upstream: OK

• builds under >= 1 archs, others excluded: OK

  note: do you plan to get it into F-11 that fast? otherwise we can still
enable ppc* builds, at least for Rawhide

• build dependencies complete: OK
• locales handled using %find_lang, no %{_datadir}/locale: N/A

• own all directories: FAIL
  oops, bug. Nobody owns this! Could you update gnome-do so it creates
%{_libdir}/gnome-do/plugins and own it?  

• no dupes in %files: OK
• permission: OK
• %clean RPM_BUILD_ROOT: OK
• macros used consistently: OK
• Package contains code: OK
• clean buildroot before install: OK
• filenames UTF-8: OK

SHOULD
• package build in mock on all architectures: PPC unknown

• package functioned as described:
  This one is problematic. On Rawhide x86_64, none of the docklets show up on
the dock. I could configure the Weather docklet, after which it does show an
icon in the list of docklets, but it does not appear on the dock. All the
others have the package icon in the listing and do not show up.


• scriplets are sane: OK

• other subpackages should require versioned base
• if main pkg is development-wise, pkgconfig can go in main package
• require package not files

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.