[Bug 493013] Review Request: dzen2 - A general purpose messaging and notification program

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=493013





--- Comment #3 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-08-25 02:59:21 EDT ---
(In reply to comment #2)
> >  - Not sure if you need to use prefix in the configure and install sections as
> > the {_prefix} macro is automatically appended to the build, even if source
> > default is /usr/local/ it doesn't end there. At least from the package I built
> > that defaults to /usr/local/ this is true. 
> 
> I am very sure that prefix is needed at least in %install, because it does not
> use any special build system like autotools oder cmake. There the path is
> passed to the makefiles using the %configure or %cmake macro. But here only
> plain make files are used.  

Some programs need to set the prefix also in the build phase, if paths are hard
coded with definitions in the source code. This is not the case here. Use just

export CFLAGS="%{optflags}"
export LDFLAGS="%{optflags}"
make %{?_smp_mflags} DZEN_XINERAMA=1 DZEN_XPM=1
make -C gadgets %{?_smp_mflags}

in %build and

rm -rf $RPM_BUILD_ROOT
make install DESTDIR=$RPM_BUILD_ROOT PREFIX=%{_prefix}
make -C gadgets install DESTDIR=$RPM_BUILD_ROOT PREFIX=%{_prefix}

in %install.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.