[Bug 518316] Review Request: vanessa_adt - Library of Abstract Data Types

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518316


Andrew Colin Kissa <andrew at topdog.za.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #5 from Andrew Colin Kissa <andrew at topdog.za.net>  2009-08-25 03:59:18 EDT ---

OK: rpmlint must be run on every package

rpmlint rpmbuild/RPMS/i586/vanessa_adt-*
vanessa_adt-devel.i586: W: no-documentation
6 packages and 0 specfiles checked; 0 errors, 1 warnings.


OK: The package must be named according to the Package Naming Guidelines
OK: The spec file name must match the base package
FIX: The package must meet the Packaging Guidelines

- Please add the %{?_smp_mflags} macro to the make command

OK: The package must be licensed with a Fedora approved license
OK: The License field in the package spec file must match the actual license
OK: License text included
OK: The spec file must be written in American English
OK: The spec file for the package MUST be legible
OK: The sources used to build the package must match the upstream source

sha256sum vanessa_adt-0.0.7.tar.gz rpmbuild/SOURCES/vanessa_adt-0.0.7.tar.gz 
61ae87d1e0f6edaee423fc68d6b6dd5355b1a9bf8d17ed9e9047fc9e3459c0fd 
vanessa_adt-0.0.7.tar.gz
61ae87d1e0f6edaee423fc68d6b6dd5355b1a9bf8d17ed9e9047fc9e3459c0fd 
rpmbuild/SOURCES/vanessa_adt-0.0.7.tar.gz

OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture
N\A: ExcludeArch
OK: All build dependencies must be listed in BuildRequires
N\A: The spec file MUST handle locales properly
OK: Must call ldconfig in %post and %postun
N\A: If the package is designed to be relocatable
OK: A package must own all directories that it creates
OK: A Fedora package must not list a file more than once
OK: Permissions on files must be set properly
OK: Each package must have a %clean section
OK: Each package must consistently use macros
OK: The package must contain code, or permissable content
N\A: Large documentation files must go in a -doc subpackage
N\A: If a package includes something as %doc, it must not affect the runtime of
the application
OK: Header files must be in a -devel package
N\A: Static libraries must be in a -static package
N\A: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
OK: Library files that end in .so (without suffix) must go in a -devel package
OK: In the vast majority of cases, devel packages must require the base package
OK: Packages must NOT contain any .la libtool archives
N\A: Packages containing GUI applications must include a %{name}.desktop file
OK: Packages must not own files or directories already owned by other packages
OK: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
OK: All filenames in rpm packages must be valid UTF-8

Fix the smp flags before import i have tested and it does build with the flags
set. Otherwise all looks good.


-------------------------------------------------------------------
    This package (vanessa_adt) is APPROVED by topdog
-------------------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.