[Bug 517497] Review Request: perl-Nagios-Plugin - Family of perl modules to streamline writing Nagios plugins

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517497


Emmanuel Seyman <emmanuel.seyman at club-internet.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #3 from Emmanuel Seyman <emmanuel.seyman at club-internet.fr>  2009-08-25 04:11:32 EDT ---
Review:
+ package builds in koji (dist-f12).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1631629
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
7f5e00a3d683b1d39b169d9d772de33b  Nagios-Plugin-0.33.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=16, Tests=969,  6 wallclock secs ( 0.29 usr  0.02 sys +  5.01 cusr  0.17
csys =  5.49 CPU)
Result: PASS
+ Package  perl-Nagios-Plugin-0.33-1.fc12.noarch =>
Provides: perl(Nagios::Plugin) = 0.33
          perl(Nagios::Plugin::Config)
          perl(Nagios::Plugin::ExitResult)
          perl(Nagios::Plugin::Functions) = 0.33
          perl(Nagios::Plugin::Getopt)
          perl(Nagios::Plugin::Performance)
          perl(Nagios::Plugin::Range)
          perl(Nagios::Plugin::Threshold)
Requires: perl(Carp)
          perl(Exporter)
          perl(File::Basename)
          perl(File::Spec)
          perl(Getopt::Long)
          perl(Math::Calc::Units)
          perl(Nagios::Plugin::Config)
          perl(Nagios::Plugin::Functions)
          perl(Nagios::Plugin::Range)
          perl(Nagios::Plugin::Threshold)
Requires: perl(Carp)
          perl(Exporter)
          perl(File::Basename)
          perl(File::Spec)
          perl(Getopt::Long)
          perl(Math::Calc::Units)
          perl(Nagios::Plugin::Config)
          perl(Nagios::Plugin::Functions)
          perl(Nagios::Plugin::Range)
          perl(Nagios::Plugin::Threshold)
          perl(Params::Validate) perl(base)
          perl(constant)
          perl(overload)
          perl(strict)
          perl(vars)
          perl(warnings)
+ Not a GUI application

Should:
1) License text is not included in package.

This module does not contain the text of the licenses it is licensed under.
Please contact upstream and encourage them to correct this mistake.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.