[Bug 480724] Review Request: djbdns - A Domain Name System by D. J. Bernstein

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480724





--- Comment #46 from pjp <pj.pandit at yahoo.co.in>  2009-08-25 05:32:44 EDT ---
  Hello Tom,

First of all thank you so much for your suggestions, I really appreciate it.

(In reply to comment #45)
>  Recommendation:  include one initscript per service and make the names of
> the initscripts match the services they control.

  Okay, I'll do the changes.

> Second, the package is missing some important parts of djbdns -- axfdns,
> walldns, and rbldns, for example.  While these parts are probably used less
> often than dnscache or tinydns, they are well established within DJB's bundle,
> and most people will expect them to be included in any package calling itself
> "djbdns".  Recommendation:  include the missing pieces.

  Yes, they are in the queue and will be released in due course.

> Recommendation: split the package into logical subpackages,
> following Pavel Lisý's scheme, which makes a lot of sense from an
> administrator's point of view (and ought to be immediately understandable
> to anyone familiar with how to deploy from DJB's bundle).

  I understand the point, but when I look at so many rpms/subpackages, it just
appears to be confusing to me. Anyway, I'll look at the sub-packaging again and
try to do it.

  I was confused about, the few client tools like dnsip/dnsq/dnsname etc. and
with which server(dnscache/tinydns) should I package them or to make a separate
sub package for them.

> Fourth, DJB's bundle relied upon the multilog program from daemontools to
> handle logging, whereas our proposed package writes to log files directly.
> But multilog did more than just write to files; it also inserted timestamps,
> which our logs lack.  Timestamps are essential in system logs, so we must
> put them back in somehow.  Maybe we could use syslog or bring back multilog. 
> Recommendation:  Restore the timestamps in logs.

  Yeah, I'm working on the logging part as well, will do the necessary changes.

> This package is looking great.  I think it's just a few tweaks away from being
> both a good Fedora package and a faithful representation of everything that
> made DJB's bundle great.  Keep up the good work!

  Thanks a lot Tom, I sincerely appreciate it.

Thank you.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.