[Bug 510743] Review Request: aranym - Atari Running on Any Machine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=510743





--- Comment #16 from Andrea Musuruane <musuruan at gmail.com>  2009-08-25 10:49:14 EDT ---
(In reply to comment #15)
> 5. That's really a bug in zlib.

If so, report a bug against zlib.

> 6. I've used requires(hint) instead.

AFAIK "requires(hint)" is exactly the same of "requires" in Fedora, bringing in
something that doesn't exist in Fedora. Therefore it will be impossible to
install aranym. 

You'll be able to include this after an afros package will be submitted for
review and approved in Fedora.

Until then, I do think that a README is the right solution for this problem.

> 9. That makes debugging of build problems harder, and can make the debuginfo
> package incomplete.  rpmlint should really be fixed, and configuring in a
> subdir should be supported by default.  IMHO srcdir != builddir should be the
> norm.

I disagree, but as I'm not the official reviewer, I let this decision to him.

> The included spec file uses --disable-nat-debug as well.

This is not a good reason. For example other distributions don't disable it.
Moreover, upstream spec files are often badly written, seldom updated and never
follow Fedora guidelines. So, there should be some reason to disable it
different from someone is doing this but I don't know why.

> 10. That wouldn't change anything since the installation won't preserve
> timestamps anyway.  And I've already fixed it upstream.

What have you fixed upstream: the preservation of timestamps or the encoding of
the files? 

Anyway, as it is now, this loop will lose the timestamps of the original files:

for f in AUTHORS ChangeLog; do
  iconv -f ISO-8859-1 -t UTF-8 $f > $f.new
  mv $f.new $f
done

> 15. The things in /usr/share/aranym are part of the emulation.  

Even the README files? This is not the right place for documentation and files
are not tagged like docs.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.