[Bug 497833] Review Request: tuna - Application tuning GUI & command line utility

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497833





--- Comment #10 from Arnaldo Carvalho de Melo <acme at redhat.com>  2009-08-26 10:14:19 EDT ---
(In reply to comment #9)
> Hello Arnaldo,
> 
>   Please consider the following comments:
> 
> 1) oscilloscope.noarch: W: name-repeated-in-summary Oscilloscope
> 
> Here:  "Summary: Generic Oscilloscope" 
> 
>    Are there other good summary that doesn't use "Oscilloscope" word?

Replaced with:

Summary: Generic graphical signal plotting tool

> 2) oscilloscope.noarch: E: explicit-lib-dependency python-matplotlib
> 
> It seems that rpmlint confused by "lib" string wrongly, concluding that it is a
> package that contains an ELF shared library that should be depended on
> automatically. IMO, it's ok.

Ah, that makes sense, agreed.

> 3) tuna.noarch: E: non-executable-script
> /usr/lib/python2.6/site-packages/tuna/oscilloscope.py 0644 /usr/bin/python
> 
>    Will oscilloscope.py be executed (fix permission) or not? 
> If not, I think that /usr/bin/python line could be removed.

Done

> Cheers,
> Douglas  

Thanks!

New files at:

http://fedorapeople.org/~acme/tuna/tuna-0.9-3.fc11.src.rpm
http://fedorapeople.org/~acme/tuna/tuna.spec
http://userweb.kernel.org/~acme/tuna/tuna-0.9.tar.bz2

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.