[Bug 519482] Review Request: zikula-module-feeds - RSS feeds module for zikula

bugzilla at redhat.com bugzilla at redhat.com
Thu Aug 27 01:05:27 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519482


Toshio Ernie Kuratomi <a.badger at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |a.badger at gmail.com




--- Comment #1 from Toshio Ernie Kuratomi <a.badger at gmail.com>  2009-08-26 21:05:26 EDT ---
Quick prereview:
* Licensing looks good.. Probably should be GPL+ or GPLv2+ though -- there's no
mention of which GPL version in this package.  zikula itself says it's GPLv2+.
* Same comment about source as zikula-module-pagemaster -- since the link is
generated everytime a download is requested, you need to have a comment that
tells how to get the source instead of the URL in the Source0 (since that won't
work for subsequent downloaders).

I see nothing in here that will need extra work.  I'll do a full review of this
tonight or tomorrow if no one else gets to it first.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list