[Bug 519302] Review Request: eog-plugins - A collection of plugins for the eog image viewer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519302


Dan Horák <dan at danny.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Dan Horák <dan at danny.cz>  2009-08-27 05:45:18 EDT ---
formal review is here, see the notes below:

OK source files match upstream:
     1a6786f0550f84ab0c99ab540ec344ed8d6b1f05  eog-plugins-2.27.91.tar.bz2
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK* license field matches the actual license.
OK license is open source-compatible (GPLv2+). License text included in
package.
OK latest version is being packaged.
OK BuildRequires are proper.
OK* compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
OK rpmlint is silent.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK no scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.


- the champlain and postr plugins should add license header into their source
files
- the build flags were checked directly in the Makefiles because the build
itself is non-verbose, you should switch to verbose mode either in configure or
build with "make V=1"

This package is APPROVED, just enable the verbose build mode during the import.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.