[Bug 518189] Review Request: java-augeas - Java bindings for Augeas

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518189


Dan Horák <dan at danny.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |dan at danny.cz
               Flag|                            |fedora-review?




--- Comment #1 from Dan Horák <dan at danny.cz>  2009-08-27 06:26:05 EDT ---
formal review is here, see the notes below:

OK source files match upstream:
     1f5de83f1d17e11b184f72c0e5dc8d4536cbac23  java-augeas-0.0.1.tar.gz
OK package meets naming and versioning guidelines.
BAD specfile is properly named, is cleanly written and uses macros
consistently.
OK dist tag is present.
OK license field matches the actual license.
OK license is open source-compatible (LGPLv2+). License text included in
package.
OK latest version is being packaged.
OK BuildRequires are proper.
N/A compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
N/A debuginfo package looks complete.
BAD rpmlint is silent.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK no scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.


- Prefix tag is not be used in Fedora
(https://fedoraproject.org/wiki/Packaging/Guidelines#Relocatable_packages)
- the spec has subtle differences compared to the official ant-based template
(https://fedoraproject.org/wiki/Packaging:Java#ant_2)
    - cp doesn't preserver attributes = "-p" is missing
    - the javadocs are installed into a versioned dir
- rpmlint complains a bit
java-augeas.src:4: W: hardcoded-prefix-tag augeas
    => remove the tag
java-augeas.src: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 1)
    => use only one of them
java-augeas-javadoc.noarch: W: non-standard-group Development/Documentation
    => it's OK

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.