[Bug 515081] Review Request: R-affy - Methods for Affymetrix Oligonucleotide Arrays

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515081


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #15 from Jason Tibbitts <tibbs at math.uh.edu>  2009-08-28 00:44:01 EDT ---
OK, it indeed builds fine and rpmlint has only the expected two complaints.
You probably want "dependency" instead of "dependance" in %description.

Note also that the templates in the R guidelines changed from using
"tetex-latex" to "tex(latex)" to use what modern tex packages use and to
prepare for the next texlive upheaval.  I'm sure the texlive packages will
provide the old symbols for compatibility so the existing packages won't break,
but at some point I guess they'll need to be fixed up.

* source files match upstream.  sha256sum:            
   b04fb91a451f75504c939e4d2b5eff6bd65ab1bf3f7417e293c8267e16fb60c8
   affy_1.22.1.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.                                                              
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
   affy.so()(64bit)
   R-affy = 1.22.1-2.fc12
   R-affy(x86-64) = 1.22.1-2.fc12
  =
   /bin/sh
   R
   R >= 2.8.0
   R-Biobase
   R-affyio
   R-preprocessCore
   R-tkWidgets
   libR.so()(64bit)
   libz.so.1()(64bit)

* %check is necessarily disabled.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files.
* scriptlets are OK (R package registration).
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.