[Bug 510734] Review Request: x11vnc - VNC server for the current X11 session

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=510734





--- Comment #58 from Axel Thimm <axel.thimm at atrpms.net>  2009-08-28 01:08:03 EDT ---
(In reply to comment #56)
> 2. According to Tom it is not necessary to re-package the tarball. However, he
> suggests that the pre-built binaries are deleted in the %prep section. My
> suggestion:
> - add "find -name '*.jar' -exec rm {} \;" to the end of the %prep section
> - add the attached patch to prevent that "make" will enter the "classes"
> directory

I don't think Tom implies to not have any java bits. Just don't use prebuilt
ones as shipped. If the Makefile supports rebuilding the jars then perhaps all
that is needed is to add some java build dependencies (and remove the java
build targets to trigger the builds).

The problem with prebuilt software is the lack of possible review and the
possibility of a Trojan import in case the upstream project has been
compromised. The shipment of jar files by the upstream authors is meant as a
convenience, just use the source and rebuild the java support.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.