[Bug 507830] Review Request: camorama - Gnome webcam viewer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507830





--- Comment #2 from Dan Horák <dan at danny.cz>  2009-08-28 02:43:32 EDT ---
formal review is here, see the notes below:

OK source files match upstream:
     ce04cd2d4abe265b19a365a515f225111dcfb969  camorama-0.19.tar.bz2
OK package meets naming and versioning guidelines.
OK* specfile is properly named, is cleanly written and uses macros
consistently.
OK dist tag is present.
OK license field matches the actual license.
OK license is open source-compatible (GPLv2+). License text included in
package.
OK latest version is being packaged.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
OK rpmlint is silent.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK correct scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
OK GUI app with desktop file


- comments should be added about the status and purpose of the patches
- GConf schemas are installed during build, --disable-schemas or exported
environment variable is missing, see
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GConf for details

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.