[Bug 510734] Review Request: x11vnc - VNC server for the current X11 session

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=510734





--- Comment #60 from Christian Krause <chkr at plauener.de>  2009-08-28 05:42:32 EDT ---
(In reply to comment #58)
> (In reply to comment #56)
> I don't think Tom implies to not have any java bits. Just don't use prebuilt
> ones as shipped. If the Makefile supports rebuilding the jars then perhaps all
> that is needed is to add some java build dependencies (and remove the java
> build targets to trigger the builds).

Yes and no. ;-)
1. The java client doesn't build out of the box just by by the global "make".
There are some manual steps necessary. However, the pre-built binaries would be
installed when using "make install". 

2. On the other hand, I was under the expression that we don't want to ship the
clients at all. If this is the case, we must make sure that they don't go into
the binary rpm. 
The safest way to achieve this is to delete them as early as possible in the
%prep section. If we decide later to add them, we can just remove the patch and
add probably some commands in the %build section to build them, too. 

(In reply to comment #59)
> (In reply to comment #55)
> > (In reply to comment #54)
> > > At a minimum, you must rebuild those jars from source. Assuming that you have
> > > the source and are able to do that, I think you are safe to simply delete the
> > > bundled prebuilt jars during %prep, and do not need to make a custom tarball.  
> > 
> > Thanks for doing the final call. Completely fine with me and easier for
> > packaging. ;-)  
> 
> Hm... I must rebuild it before make decision what it may be excluded?? In this
> case, will be best solution include it also in package... Sic, it require
> additional time in any case.  

I think there is a misunderstanding. If we don't want to ship the java client,
we can just delete the binaries and we don't need to rebuild them. The only
minor request I had was to move the deletion from the %install section to the
%prep section to be on the safe side, that no any change in the build system of
upstream would leak them accidentely in later...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.