[Bug 519138] Review Request: libbs2b - Bauer stereophonic-to-binaural DSP library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519138


Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |martin.gieseking at uos.de
         AssignedTo|nobody at fedoraproject.org    |martin.gieseking at uos.de
               Flag|                            |fedora-review?




--- Comment #1 from Martin Gieseking <martin.gieseking at uos.de>  2009-08-28 14:01:26 EDT ---
Hello Karel,

here is the review of your package. It is pretty clean. Just the
BuildRequires(pre/post) should be removed (see below).


rpmlint /var/lib/mock/fedora-11-i386/result/*.rpm
libbs2b-devel.i586: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 1 warnings.

The warning is expected and can safely be ignored.

---------------------------------
keys used in following checklist:

[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------

[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: License file(s) must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL.
    - md5 hash is 00d32ffa6461dde6a632c846da3e0a13

[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile,...
[X] MUST: All build dependencies must be listed in BuildRequires.
    - Requires(post) and Requires(pre) are redundant here (no %pre scriptlet)
    - dependency /sbin/ldconfig is determined automatically
      (see
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Shared_libraries)

[.] MUST: The spec file MUST handle locales properly. 
    - no locales

[+] MUST: Packages with shared libs must call ldconfig in %post and %postun.
[.] MUST: If the package is designed to be relocatable,...
[.] MUST: A package must own all directories that it creates.
    - doesn't create directories

[+] MUST: File must not be listed more than once in the %files listings.
[+] MUST: Permissions on files must be set properly. 
[+] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
    - no large docs

[+] MUST: Files in %doc must not affect the runtime of the application. 
[+] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
    - no static libs

[+] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
[+] MUST: .so (without suffix) must go in a -devel package.
[+] MUST: devel packages must have a Requires: %{name} = %{version}-%{release}
[+] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages with GUI applications must include a %{name}.desktop file.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: All filenames in rpm packages must be valid UTF-8.


[+] SHOULD: The reviewer should test that the package builds in mock.
    - builds in mock 

[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
    - koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=1641475

[+] SHOULD: If scriptlets are used, those scriptlets must be sane.
[+] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.