[Bug 520278] Review Request: notify-osd - Canonical's on-screen-display notification agent

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=520278


Rahul Sundaram <sundaram at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sundaram at redhat.com




--- Comment #4 from Rahul Sundaram <sundaram at redhat.com>  2009-08-30 07:59:31 EDT ---
I am not a sponsor, consider this a unofficial quick review:

Your earlier spec was inaccessible. If you don't have a proper place to upload
packages, get a Fedora account at 

https://admin.fedoraproject.org/accounts

Apply for fedorabugs group there and I will approve so that you can scp your
files to fedorapeople.org 

https://fedoraproject.org/wiki/Infrastructure/fedorapeople.org

Also, you should avoid using the trademark name "Canonical" 

https://fedoraproject.org/wiki/Packaging/Guidelines#Trademarks_in_Summary_or_Description

A better summary and description would be 

"On-screen-display notification"

and

"On-screen-display notification agent, implementing the freedesktop.org Desktop
Notifications Specification with semi-transparent click-through bubbles."

There is a typo in your conflicts and also on "initial package". Since
notification-daemon is a explicit dependency of many packages, how is a user
expected to install this package? 

You don't need to define the buildroot or remove it in %install section
anymore. 

https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

You shouldn't add explicit requires for libraries unless RPM can't detect it by
itself.

https://fedoraproject.org/wiki/Packaging/Guidelines#Requires

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.