[Bug 520278] Review Request: notify-osd - On-screen-display notification agent

bugzilla at redhat.com bugzilla at redhat.com
Mon Aug 31 08:56:08 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=520278





--- Comment #14 from Rahul Sundaram <sundaram at redhat.com>  2009-08-31 04:56:07 EDT ---
When you submit a revised spec, make sure you bump up the release and add a
changelog entry explaining the change briefly.  You don't need to define the
buildroot anymore. So you can drop, 

"BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)"

Fix the typo in

"Initial Pakcage"

rpmlint shows the changelog as incoherent. Fix that as well.  Instead of using
conflicts, the right answer would be to get the packages that directly depend
on notification-daemon to use the virtual provides called
desktop-notification-daemon instead (a file based dependency can also work but
I wouldnt suggest that). You have to file a RFE against them

# repoquery --whatrequires --all  notification-daemon

blueman-0:1.10-4.fc12.i686
notification-daemon-engine-nodoka-0:0.1.0-10.fc12.i686

---

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list