[Bug 506825] Review Request: bickley - A meta data management API and framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506825





--- Comment #17 from Peter Robinson <pbrobinson at gmail.com>  2009-08-31 12:09:20 EDT ---
(In reply to comment #16)
> Sorry for the delay, it was a busy week for me.

NP: know the feeling all too well.

> Bad:
> - Some redundant BRs that *could* (not must) be removed:
> clutter-devel and clutter-gtk-devel require gtk2-devel
> clutter-gtk-devel and clutter-gst-devel require clutter-devel

Dropped, added gstreamer-devel to the list.

> - I wonder if "Applications/Multimedia" really is the proper group tag for a
> framework.

I couldn't find a better one and that's what gstreamer uses.

> - Are sqlite and xdg-user-dirs really required? I dont't see them referenced in
> the source

Dropped.

> - %configure is still run twice.

I think this is fixed. Seems there's a number of different ways to fix this,
the cleanest being the one that's part of gnome-common.

> - %configure correctly uses --disable-rpath and --disable-schemas, but now
> during build I see:
>
> configure: WARNING: unrecognized options: --enable-maintainer-mode
> ...
> configure: WARNING: unrecognized options: --disable-rpath, --disable-schemas
> 
> the first is a bug in autogen.sh and should be fixed upstream, but the second
> ones need fixing in the package. --disable-shemas can be dropped as you already
> have
> export GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL=1
> in %install
> 
> This leaves --disable-rpath. I'm pretty sure I checked that it works, but
> AFAIKS it can be dropped too as the applications contain no rpath (tested with
> chrpath).  

Fixed. The rpath one was added at some point I think when a previous build
needed it. I'll bring up the the --enable-maintainer-mode issue with upstream.

SPEC: as above
SRPM: http://pbrobinson.fedorapeople.org/bickley-0.4.3-6.fc11.src.rpm
koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1646385

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.