[Bug 515832] Review Request: libtelnet - TELNET protocol handling library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515832


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?




--- Comment #8 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-08-31 12:57:26 EDT ---
(In reply to comment #7)
> Replaced use of %makeinstall.  I got that from the Fedora examples.  I'm
> getting rather irritated by the Fedora documentation being contradictory and
> out of date for package building.

If you find something contradictory on Fedora documentation, please
notice it on fedora-packaging mailing list.

For -2:

* Packaging structure
  - If you want to split binaries under %_bindir into a subpackage,
    usually such subpackage is named as "-utils" on Fedora.

* About make install
  - I still recommend to add 'INSTALL="install -p"' option to
    'make install' to keep timestamps on installed files
    (especially on header files to be installed)

* Documents
  - You don't have to include a document file to all subpackages.
  - Including license text (in this package "COPYING") to the main
    package is rather mandatory

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.