[Bug 520500] Review Request: maven-enforcer-rule-api - Generic interfaces needed by maven-enforcer-plugin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=520500


Andrew Overholt <overholt at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |overholt at redhat.com
         AssignedTo|nobody at fedoraproject.org    |overholt at redhat.com
               Flag|                            |fedora-review?




--- Comment #2 from Andrew Overholt <overholt at redhat.com>  2009-08-31 16:08:31 EDT ---
- no differences in source I get vs. what's in the SRPM
X please make lines 19, 20, 90, and 95 < 80 characters
? should we make the versioned BRs and Rs on maven2 be >= 2.0.8?
X let's drop the with_maven/without_maven junk at the top
- macros sane
- clean used appropriately
- licensing fine
- description and summary fine
X please add a changelog entry
- builds fine
- rpmlint output is fine (doesn't like maven fragment in /etc and no files to
mark as documentation)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.