[Bug 520501] Review Request: maven-archiver - Maven Archiver

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=520501





--- Comment #3 from Alexander Kurtakov <akurtako at redhat.com>  2009-08-31 16:45:15 EDT ---
(In reply to comment #2)
> - naming and licensing fine
> X please wrap lines 47, 104, and 108 at <= 80 characters
Done.
> X please add a changelog entry
Done.
> X please only own the fragment %{name} and specific pom
> (JPP-maven-archiver.pom)
Done
> X please drop the with_maven/without_maven stuff at the top of the .spec
Done
> - sources fine (I get no differences between my export and the one in the
> tarball)
> ? should we make the maven2 R/BR >= 2.0.8?
Done
> ? let's make the description "The Maven Archiver is used by other Maven plugins
> to handle packaging."
Done.
> - cleaning done appropriately
> - builds fine
> - macros good
> - rpmlint output is fine:

New sources:
Spec URL: http://akurtakov.fedorapeople.org/maven-archiver.spec
SRPM URL: http://akurtakov.fedorapeople.org/maven-archiver-2.2-2.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.