[Bug 506855] Review Request hornsey - The moblin media player

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506855


Christoph Wickert <cwickert at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #10 from Christoph Wickert <cwickert at fedoraproject.org>  2009-08-31 19:36:26 EDT ---
(In reply to comment #7)
> Christoph: Did you apply the patch?  

Erm, obviously not. :(


TBD items from comment #5:

$ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/hornsey-*
hornsey-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/hornsey-0.3/src/hrn-texture-cache.h
hornsey-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/hornsey-0.3/src/hrn-texture-cache.c
3 packages and 0 specfiles checked; 0 errors, 2 warnings.

chmod -x src/hrn-texture-cache.* in %prep will fix this.

OK - MUST: all build dependencies are listed in BuildRequires.
OK - SHOULD: builds in mock.
OK - SHOULD: compiles and builds into binary rpms on all supported
architectures.
OK - SHOULD: functions as described, although there are *lots* of clutter
related warnings. I also noted that bognor-regis-daemon will continue playing
after hornsey was closed, but I guess this is intended.


Remaining issues from comment #5:
OK - bognorregis-0.4.10.patch applied
OK - Description ends with a dot.
OK - Description enhanced, but shouldn't it be "an Image" instead of "a Image"?

OK - update-desktop-database sriptlet correct.
OK - AUTHORS and README added to %doc


Fix the rpmlint error, add the missing 'n' in the description and consider

hornsey-0.3-2.fc11.src.rpm APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.