[Bug 226165] Merge Review: mt-st

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226165


Miroslav Lichvar <mlichvar at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dhorak at redhat.com
               Flag|                            |fedora-review?




--- Comment #4 from Miroslav Lichvar <mlichvar at redhat.com>  2009-12-01 11:55:26 EDT ---
Review follows:

OK source files match upstream:
fdd5f5ec673c9f630a102ceff7612774  mt-st-1.1.tar.gz

OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK build root is correct.
OK license field matches the actual license.
OK license is open source-compatible. License text included in package.
OK latest version is being packaged.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock.
OK debuginfo package looks complete.
NO rpmlint is silent.
mt-st.x86_64: W: service-default-enabled /etc/rc.d/init.d/stinit
mt-st.x86_64: E: no-status-entry /etc/rc.d/init.d/stinit
mt-st.x86_64: W: no-reload-entry /etc/rc.d/init.d/stinit
mt-st.x86_64: E: subsys-not-used /etc/rc.d/init.d/stinit
mt-st.x86_64: W: incoherent-init-script-name stinit ('mt-st', 'mt-std')

Enabled by default and incoherent name are ok, but the script should be
probably updated to match the Fedora init script guidelines.

OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK scriptlets are sane.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.