[Bug 543383] Review Request: emacs-irsim-mode - Irsim mode for emacs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=543383





--- Comment #1 from Shakthi Kannan <shakthimaan at gmail.com>  2009-12-02 06:24:29 EDT ---
#001: Use %{__rm} instead of rm.
      Use %{__mkdir} instead of mkdir.

#002: Use %{__install} instead of having to define % global INSTALL.

#003: In %prep, %build section, you are doing the same (cd) twice. Not
required.

#004: There is no README file?

#005: These are redundant!

  %global pkg emacs-irsim-mode
  %global common_name irsim-mode
  %global pkgname Emacs-irsim-mode
  %global pkgdir %{buildroot}%{emacs_lispdir}/irsim-mode/
  %global ver 0.1
  %global rel 1

#006: Instead of 'ver', 'rel', you can call them something else? Avoid
short-hand as much as possible. .spec needs to be readable.

#007:

  "This package contains the elisp source files for 
  Emacs-irsim-mode under GNU Emacs.
  You do not need to install this package 
  to run Emacs-irsim-mode. 
  Install the emacs-irsim-mode package 
  to use %{pkgname}  with GNU Emacs."

The grammar in the above is incorrect. You just copied the text? :) Why do you
need to give instructions on packaging it in the description? Just keep the
following in the description:

  This package contains elisp source files for Emacs-irsim-mode for use with
  GNU Emacs.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.