[Bug 543383] Review Request: emacs-irsim-mode - Irsim mode for emacs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=543383





--- Comment #5 from Chitlesh GOORAH <chitlesh at gmail.com>  2009-12-02 09:20:35 EDT ---
#001: Description
Use the following description instead :
32  IRSIM is a switch-level simulator for digital logic circuits.
33  This is an Emacs mode for editing IRSIM netlists. It provides
34  syntax highlighting and an extremely pleasant method if indentation.

#002: Start file

It should better have the following since I think it should be autoload
49  (autoload 'irsim-mode "irsim-mode" nil t)
50  (setq auto-mode-alist
51        (cons '("\\.sim$" . irsim-mode) auto-mode-alist))


#003: compile it with

emacs -batch -f batch-byte-compile %{pkg}.el

#004 Directory ownership and duplicates

Verify why you are having double directory ownership in the %files section for
%{emacs_startdir}

#005 Keep the spec file simple

replace  cd %{_builddir}/%{name}-%{version} by cd %{name}-%{version}

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.