[Bug 537431] Review Request: mono-bouncycastle - Bouncy Castle Crypto Package for Mono

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=537431


Thomas Janssen <thomasj at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |thomasj at fedoraproject.org
         AssignedTo|nobody at fedoraproject.org    |thomasj at fedoraproject.org
               Flag|                            |fedora-review?




--- Comment #5 from Thomas Janssen <thomasj at fedoraproject.org>  2009-12-02 14:03:04 EDT ---
+ rpmlint is fine for a mono package. The permission is needed to run the
script.

rpmlint rpmbuild/RPMS/x86_64/mono-bouncycastle-1.5-3.fc11.x86_64.rpm
srpm-review-test/mono-bouncycastle-1.5-3.fc13.src.rpm
mono-bouncycastle.x86_64: E: no-binary
mono-bouncycastle.x86_64: W: only-non-binary-in-usr-lib
mono-bouncycastle.src: W: strange-permission bccrypto-generate-zip.sh 0755
2 packages and 0 specfiles checked; 1 errors, 2 warnings.

+ The package must be named according to the Package Naming Guidelines .
+ The spec file match the base package %{name}, in the format %{name}.spec
unless your package has an exemption.
+ The package meets the Packaging Guidelines.
+ The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
! The License field in the package spec file must match the actual license.

Part of the source states: Apache Software License 1.1 (ASL 1.1)
The Webpage says: MIT X11

Change the license to: MIT with ASL 1.1 

+ The spec file is written in American English.
+ The spec file is legible.
+ The sources used to build the package must match the upstream source, as
provided in the spec URL.
md5 d400421918c0c20f2f53fa003e25eb11

+ It compiles
+ ExcludeArch done.
+ BuildRequires listed.
+ Packages must NOT bundle copies of system libraries.
+ Package owns all directories that it creates.
+ Permissions are set properly.
+ %clean section
+ Macros usage
+ The package must contain code, or permissable content.
+ %doc handling
+ At the beginning of %install, each package MUST run rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).

Package will be approved after you corrected the license field.


-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.