[Bug 542500] Review Request: php-pear-OLE - Package for reading and writing OLE containers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=542500


Remi Collet <fedora at famillecollet.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |fedora at famillecollet.com
               Flag|                            |fedora-review+




--- Comment #3 from Remi Collet <fedora at famillecollet.com>  2009-12-02 16:15:54 EDT ---
REVIEW:

+ rpmlint is ok
php-pear-OLE.src: I: checking
php-pear-OLE.noarch: I: checking
php-pear-OLE.noarch: W: no-documentation
2 packages and 1 specfiles checked; 0 errors, 1 warnings.
+ package name ok
+ spec file name ok
+ package meet the PHP Guidelines
+ License ok : PHP
+ License is upstream 
+ spec in english and legible
+ no license file in sources is provided
+ sources match the upstream sources
232a44e1da145afc6f6a5b791ae605f8  OLE-1.0.0RC1.tgz
+ Source URL ok
+ build  on F10.x86_64
+ BuildRequires (php-pear >= 1:1.4.9-1.2) ok
+ no locale
+ no .so
+ own all directories that it creates
+ no duplicate file
+ %defattr ok
+ %clean section
+ use macros consistently
+ contain code
+ no documentation
+ no devel
+ no pkgconfig
+ no sub-package
+ no GUI
+ don't own files or directories already owned by other packages
+ %install start with rm -rf 
+ valid UTF-8
+ build in koji
+ no test suite
+ scriptlets ok
- Final Requires ok
/usr/bin/pear 
+ Final Provides ok
php-pear(OLE) = 1.0.0
php-pear-OLE = 1.0.0-0.2.rc1.fc8


In /usr/share/pear/OLE.php
=> require_once 'PEAR.php';

So you must add
Requires: php(PEAR)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.