[Bug 541992] Review Request: perl-PDF-Create - Create PDF files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541992





--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-12-03 03:37:06 EDT ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1842889
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url (sha1sum)
474428dcbf1833d71a4dff5fc84cda6916d95aba  PDF-Create-1.04.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=5, Tests=9,  0 wallclock secs ( 0.04 usr  0.01 sys +  0.32 cusr  0.04
csys =  0.41 CPU)
+ Package perl-PDF-Create-1.04-1.fc13.noarch =>
Provides: perl(PDF::Create) = 1.04 perl(PDF::Create::Outline) = 1.00
perl(PDF::Create::Page) = 1.00 perl(PDF::Image::GIF) = 1.00
perl(PDF::Image::JPEG) = 1.00
Requires: /usr/bin/perl perl(CGI) perl(Carp) perl(Data::Dumper) perl(Exporter)
perl(FileHandle) perl(PDF::Create) perl(PDF::Create::Outline)
perl(PDF::Create::Page) perl(PDF::Image::GIF) perl(PDF::Image::JPEG)
perl(integer) perl(strict) perl(vars)
+ Not a GUI application

I can't find licence information. Can you point me if I have missed it? If its
not there then ask upstream to include it in each .pm file and/or also in
README or separate license text file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.