[Bug 525927] Review Request: incollector - Information collector for various kinds of information

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=525927


Kalev Lember <kalev at smartlink.ee> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #8 from Kalev Lember <kalev at smartlink.ee>  2009-12-03 05:37:08 EDT ---
(In reply to comment #5)
> Thanks for the patch. It's not a blocker to use sed, though i changed it to use
> patch since there was already a patch, for consistency.

Of course, using sed is no problem. However, the sed command was just a
workaround. The reason why I came up with the patch is that it fixes the root
cause, and I am sure upstream is glad to apply it. For you personally using sed
is probably easier, but if you submit the patch to upstream, you might be able
to eventually remove the workaround in a future release.


> > ! Consider removing %{_datadir}/pixmaps/%{name}.ico at the end of %install. I
> > very much doubt anything uses .ico files in Fedora when there's a matching .png
> > file in %{_datadir}/pixmaps/.  
> 
> The ico is used inside the app it seems. Removing it breaks the compiling. I
> dont want to patch the software to make it use a png.

Yes, the .ico file gets embedded in the .exe file during %build section.
However, what I was saying is that you might want to remove it at the end of
%install from %{buildroot} (compiling is all done by that time). As I
understand it, the .ico file gets embedded in the .exe during build, and
nothing else uses it afterwards in %{_datadir}/pixmaps/. The .png is used for
desktop integration, but since .ico files are mostly Windows-specific, I very
much doubt Gnome or KDE would load them, especially if the .png file is
present. There's a small chance that incollector itself might load the .ico at
runtime, but grepping through the source gave me the impression that this is
not the case.

But this is nothing serious, and I am not sure if it's even worth removing it.
Just pointed it out for you.


APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.