[Bug 226211] Merge Review: openhpi
bugzilla at redhat.com
bugzilla at redhat.com
Thu Dec 3 18:02:25 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226211
Michal Hlavinka <mhlavink at redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--- Comment #3 from Michal Hlavinka <mhlavink at redhat.com> 2009-12-03 13:02:22 EDT ---
in short:
Legend: + = PASSED, - = FAILED, 0 = Not Applicable
- MUST[1]: rpmlint must be run on every package. The output should be posted in
the review
+ MUST: package named according to the Package Naming Guidelines
+ MUST: The spec file name must match the base package %{name}
+ MUST: The package must meet the Packaging Guidelines .
+ MUST: The package licensed with a Fedora approved license and meets the
Licensing Guidelines
+ MUST: The License field in the package spec file matches the actual license
+ MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.[4]
+ MUST[2]: The spec file must be written in American English.
+ MUST[3]: The spec file for the package MUST be legible.
- MUST[4]: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task
+ MUST: The package successfully compiles and builds into binary rpms on at
least one primary architecture
+ MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch
+ MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines
+ MUST: The spec file handles locales properly. This is done by using the
%find_lang macro
+ MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun. [10]
+ MUST: Packages must NOT bundle copies of system libraries
+ MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker
+ MUST: Package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory
+ MUST: Package must not list a file more than once in the spec file's %files
listings
+ MUST: Permissions on files must be set properly. Every %files section must
include a %defattr(...) line.
+ MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
+ MUST: Each package must consistently use macros
+ MUST: The package must contain code, or permissable content
0 MUST: Large documentation files must go in a -doc subpackage
+ MUST: If a package includes something as %doc, it must not affect the runtime
of the application
+ MUST: Header files must be in a -devel package
0 MUST: Static libraries must be in a -static package
+ MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
- MUST[1]: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package
+ MUST: devel packages must require the base package using a fully versioned
dependency: Requires: %{name} = %{version}-%{release}
+ MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built
+ MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section
+ MUST: Packages must not own files or directories already owned by other
packages
+ MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}
(or $RPM_BUILD_ROOT)
fails, but this is no longer required (
https://fedoraproject.org/wiki/Packaging/Guidelines#PreppingBuildRootForInstall
)
+ MUST: All filenames in rpm packages must be valid UTF-8
--------------------------------
comments:
1) rpmlint *.spec *.src.rpm x86_64/*
openhpi.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/openhpi/libsnmp_bc.so
openhpi.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/openhpi/libipmi.so
openhpi.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/openhpi/libsimulator.so
openhpi.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/openhpi/libwatchdog.so
openhpi.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/openhpi/libipmidirect.so
openhpi.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/openhpi/liboa_soap.so
openhpi.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/openhpi/libilo2_ribcl.so
openhpi.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/openhpi/libsysfs2hpi.so
https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages :
""".... The following are examples of file types which should be in -devel:
* Header files (e.g. .h files)
* Unversioned shared libraries (e.g. libfoo.so).
"""
these files should go to -devel package
---------
openhpi.x86_64: E: non-standard-dir-perm /var/lib/openhpi 01777
are these permissions really required? I've done only quick testing/googling
(without proper configuration), but didn't find anything about this
-----------------
openhpi-libs.x86_64: W: obsolete-not-provided openhpi
why openhpi-libs obsoletes openhpi? for version specified, there were no
openhpi-libs provided, but this line would lead to yum replacing openhpi with
just openhpi-libs -> openhpid and other files will be missing
what is your rationale for this?
-----------
openhpi-libs.x86_64: W: no-documentation
no problem with this one
2) Correct english - see WordUsage.html
%description
hot swap
--------
Correct. Two words, lower case. Capitalize when used at the beginning of a
sentence only. Do not use ‘hotswap’ or ‘hot-swap’.
plug-in
-------
Correct. Do not use "plugin".
A hardware or software module that adds a specific feature or service to a
larger system. For example, a number of plug-ins are available for the Netscape
Navigator browser that enable it to display different types of audio or video
messages. Navigator plug-ins are based on MIME file types.
but these are not blockers ;-)
3) too much wildcards under %files section
If upstream makes some changes to it's tarball and add/remove some files, this
is not going to catch anything. It's good practice to list at least all files
under %{_bindir} and %{_sbindir}. This will let you know if there is any
new/missing one.
4) sources does not match upstream
$ curl -s http://downloads.sourceforge.net/openhpi/openhpi-2.14.1.tar.gz |
md5sum
d41d8cd98f00b204e9800998ecf8427e -
$ cat sources
1533972a05f2ed61f3ae441ecd3df5a9 openhpi-2.14.1.tar.gz
Please fix these issues, thanks
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
More information about the Fedora-package-review
mailing list