[Bug 538190] Review Request: unicornscan - Scalable, accurate, flexible and efficient network probing

Thu Dec 3 20:19:20 UTC 2009

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=538190

manuel wolfshant <wolfy at nobugconsulting.ro> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|wolfy at nobugconsulting.ro    |
         AssignedTo|nobody at fedoraproject.org    |wolfy at nobugconsulting.ro
               Flag|                            |fedora-review+

--- Comment #3 from manuel wolfshant <wolfy at nobugconsulting.ro>  2009-12-03 15:19:17 EDT ---
Package Review
==============

Key:
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [x] Package meets the Packaging Guidelines.
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested on: F10 and F11/x86_64. fails at the moment in devel due to bug
#544039
 [x] Rpmlint output:
source RPM: unicornscan.src:39: W: configure-without-libdir-spec
-> benign
binary RPM:
unicornscan.x86_64: W: non-standard-uid /etc/unicornscan/modules.conf
unicornscan
unicornscan.x86_64: W: non-standard-gid /etc/unicornscan/modules.conf
unicornscan
unicornscan.x86_64: E: non-readable /etc/unicornscan/modules.conf 0640
-> intended for security reasons
 [x] Package is not relocatable.
 [x] Optional buildroot tag is correct (
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) )
 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
     License type:GPLv2+
 [x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package match the upstream source, as provided
in the spec URL.
     SHA1SUM of source file: 5361150afa999e68076a453072830dd23dd9bfee 
/home/wolfy/unicornscan-0.4.7-2.tar.bz2
 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [-] Package requires other packages for directories it uses.
 [-] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [x] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [x] Package does not contain any libtool archives (.la).
-> existing .la files are needed by the plugins
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [x] Package does not own files or directories owned by other packages.
 [x] Final provides and requires are sane.

=== SUGGESTED ITEMS ===
 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, i
f available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: F10 and F11/x86_64 & x86
 [x] Package should compile and build into binary rpms on all supported
architectures.
     Tested on:F10 and F11/x86_64 & x86
 [x] Package functions as described (in F10)
 [x] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [x] File based requires are sane.
 [-] %check is present and the test passes.

=== Issues ===
1. The current version cannot be compiled in fedora rawhide, as pointed out in
https://bugzilla.redhat.com/show_bug.cgi?id=
538190#c1 and https://bugzilla.redhat.com/show_bug.cgi?id=544039

2. It would be nice if you could also compile a version with mysql support
(maybe by compiling twice, once with mysql suppo
rt and once with pgsql support --having both does not really make sense despite
being theoretically possible (and done by o
ther apps)

3. If it is not too much to ask, I'd like to see the php scripts included, at
least as doc if not as a separate frontend pa
ckage. That is, presuming that they work.

================
*** APPROVED *** but please wait for the rawhide version to get fixed before
pushing to the repos
================

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.