[Bug 544295] Review Request: upower - Power management service

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=544295





--- Comment #2 from Matthias Clasen <mclasen at redhat.com>  2009-12-04 10:53:48 EDT ---
Looking at the docs, I notice that Upower.7 refers to DeviceKit(7) - that
should probably be removed.


Formal review:

package name: ok
spec file name: ok
packaging guidelines: 

Requires(post): /sbin/ldconfig
Requires(postun): /sbin/ldconfig

These are not necessary when using %post(un) -p

Requires: dbus >= %{dbus_version}
Requires: dbus-glib >= %{dbus_glib_version}
Requires: glib2 >= %{glib2_version}
Requires: polkit >= %{polkit_version}

The guidelines now have language that forbids explicit requires where an
automatic library dep suffices. You probably want the explicit dep on dbus (for
the daemon), so just add a comment there; but dbus-glib, glib2, polkit are
probably all unnecessary. Might be good to compare with what david has done in
upower.

-devel should require gtk-doc for %{_datadir}/gtk-doc/html/, I think.

mkdir -p $RPM_BUILD_ROOT%{_datadir}/doc/%{name}-%{version}
cp README AUTHORS NEWS COPYING HACKING doc/TODO
$RPM_BUILD_ROOT%{_datadir}/doc/%{name}-%{version}

Why are you doing this ? Just %doc README AUTHORS NEWS... in the file list
should suffice.

License: ok

to be continued...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.