[Bug 538327] Review Request: otpd - One Time Password daemon

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=538327





--- Comment #33 from manuel wolfshant <wolfy at nobugconsulting.ro>  2009-12-04 15:45:43 EDT ---
Skimming through the output of rpmlint (and skipping the non relevant stuff),
- the new src version has a cosmetic issue:
 otpd.src: W: mixed-use-of-spaces-and-tabs (spaces: line 12, tab: line 1)
- you forgot to upload the new source.tar.gz to googlecode
- you forgot to add a new entry in the changelog (last entry still points to
3.2.5-2, which makes rpmlint unhappy:
 otpd.x86_64: W: incoherent-version-in-changelog 3.2.5-2 ['3.2.6-1.fc13',
'3.2.6-1']
- the service is still installed as default enabled
  otpd.x86_64: W: service-default-enabled /etc/rc.d/init.d/otpd
- and you still do a service restart in %post, which, combined with the above
entry, makes the service start even on the systems where the admin decided to
stop it
- and we still have
 otpd.x86_64: W: no-reload-entry /etc/rc.d/init.d/otpd
I am not familiar at all with the code and I cannot even test as I have no
tokens, but maybe reload could be implemented as a synonym to restart ?



As a second matter, do you have any other submissions or did you perform any
package reviews? If you have, please be as kind as to point me to those
bugzilla entries. If not, please consider doing so, as this is still a
mandatory step before being sponsored.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.