[Bug 541207] Review Request: liborigin2 - library for reading OriginLab Origin 7.5 project files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541207





--- Comment #3 from Michael Schwendt <mschwendt at gmail.com>  2009-12-05 09:45:58 EDT ---
One thing that's striking is:

> * Sat Nov 25 2009 Super Cyper <supercyper AT 163 DOT com> - 06042009-1

Certainly you are not named "Super Cyper". I highly recommend you to use your
real name, also inside the .spec file and in bugzilla.redhat.com.

[...]

Skimming over the .spec file, it doesn't look bad.

> Name:                   liborigin2
> Group:                  Development/Libraries

Main library packages typically use RPM Group "System Environment/Libraries",
since they are used at run-time and not specific to developing/building
software.


> %description devel
> This package contains the header files, static libraries

Static libraries are not included, so this description isn't true.


> $ spectool liborigin2.spec 
> Source0: http://prdownload.berlios.de/qtiplot/liborigin2-06042009.zip

This URL points at a web-page instead of the .zip archive. If you cannot find
an URL that points at the archive directly (with a specific BerliOS mirror as
the last resort), it would be better to follow:
http://fedoraproject.org/wiki/Packaging/SourceURL#Troublesome_URLs

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.