[Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=537587





--- Comment #37 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-12-05 13:00:41 EDT ---
For -0.10:

* Naming
(In reply to comment #35)
> 2) I didn't rename the libdspam to dspam-libs because you can install the
> library independent of dspam, it can be used in other projects/programs. If
> someone were to write a plugin for evolution or thunderbird. the dspam package
> is only necessary for an MTA, whereas the library can be used in all sorts of
> places.

  - Fedora already many examples about this.
    e.g. There are some apprecations which requires mysql-libs, but
         not mysql or mysql-server. And there are many other
         examples.

> 3) The libdspam-X are required by the library for storage of all the token data
> it produces. So I'm not sure what to call them other than libdspam-X, I could
> rename them to dspam-plugin-X or dspam-storage-X but that implies you need the
> dspam package which you don't. So if you could advise what to do here.

   - You can name as dspam-plugin-foo or dspam-foo and this does not
     mean that dspam(-plugin)-foo requires dspam binary rpm (unless you
     write so in the spec file)

* Directory ownership issue
  - This time the following directories are not owned by any
    packages:
----------------------------------------------------------------
/usr/share/dspam/
/var/lib/dspam/txt/
----------------------------------------------------------------

(In reply to comment #36)
> Which brings me to my next question about that.
> <snip>
> %dir %{_datadir}/%{name}/sql-scripts/mysql
> %doc %attr(0644,root,root) %{_datadir}/%{name}/sql-scripts/mysql/*
> </snip>
> 
> Can I combine that into one line? I assume I can't because I want the attr to
> apply to the files and not the directory..
  - I avoid to use %attr as much as possible. (0644,root,root) permission
    on files are default's permission so if you set this permission _in
advance_,
    you don't have to write %attr(0644,root,root) explicitly.

    i.e. set permission at %install like
---------------------------------------------------------------
chmod 0644 %buildroot%_datadir/%name/*/*/*
---------------------------------------------------------------
    and I don't usually write %attr(0644,root,root) for files and
    %attr(0755,root,root) for directories.

Another thing:
* Documents
  - Add "LICENSE" files to -libs package (because including "LICENSE" text 
    to %doc is a must if it exists and all dspam related packages require
    -libs package)
  - And consider to move document files in dspam binary rpm to -libs package
    (because one can install dspam-libs package only)


And please check permission/owner/group is corrently set for all files
( especially, I don't think permission of /usr/bin/dspam is set correctly.
  Currently /usr/bin/dspam has (2511,root,root) permission (i.e. has
  setgid bit and group is root), which means when this script is executed,
  the process is always run with root group.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.