[Bug 544745] Review Request: emacs-spice-mode - SPICE Mode for GNU Emacs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=544745





--- Comment #7 from Chitlesh GOORAH <chitlesh at gmail.com>  2009-12-07 02:16:27 EDT ---
Your patch is working as expected on F-12. I'm currently testing it under F-12
and will test on centos-5 soon.

The following are some improvements that we need to make and ensure. The
spice-mode seems to be meant for proprietary spice simulators and is very old.
Thereby, we need to tune it as appropriate

#003: in the spice simulators list, obsolete  
"Nutmeg" "nutmeg"
by
"Nutmeg" "ngnutmeg"

ngnutmeg is provided by ngspice package.

#004: in the spice simulators list, please add gnucap. gnucap has a -b switch
as ngspice. So you can safely copy ngspice section and paste it for gnucap.
(create a separate patch for this). In the meantime, I'll contact Al Davis to
see whether he already has some fine tunings for emacs.

#005: ngspice still freezes emacs.

#006: In the init file, you have different file extensions and for each you
have a separate auto-mode-alist entry e.g
(setq auto-mode-alist
      (cons '("\\.sim$" . irsim-mode) auto-mode-alist))

I'm not an emacs expect: Do several entries affect the load time of emacs ?

#007: Set gnucap as default (since ngspice is freezing emacs). Remove ngspice
from the Requires and add gnucap as BR

#008: Warning for emacs >= 22

%if 0%{?fedora}
sed -i "s|process-kill-without-query|process-query-on-exit-flag|" %{pkg}.el
%endif

#009: Can you set gnucap as a default simulator and gwave as a default viewer
please ? Possibly in the init file

#010: Debatable:
If one opens a spice netlist with emacs-spice-mode, one will see the names of
proprietary spice standards: Hspice,Eldo... as my attached screenshot
demonstrates.

I think we need to replace that with "Gnucap/Ngspice" if not it will look as if
we are doing publicity for those vendors.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.