[Bug 536694] Review Request: clamtk - GUI frontend for ClamAV

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=536694





--- Comment #12 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-12-07 14:01:38 EDT ---
Well,

* License
  - Anyway please clarify the license. On Fedora "under the same terms
    as Perl itself" means "GPL+ or Artistic", however is this what
    you intend?
    https://fedoraproject.org/wiki/Packaging/Perl#License_tag

* BuildRequires
  - This srpm won't build without "BuildRequires: desktop-file-utils"
    (as this srpm calls "desktop-file-install" at %install)

* Requires
  - "Requires: desktop-file-utils" should be removed
    ( see:
     
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database )

  - Dependency for perl module related dependency must be specified
    by virtual Provides' names and not by using rpm name directly:
    https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides

  !!By the way please check if writing "Requires: perl-File-Find-Rule" (should
be
    written as perl(File::Find::Rule)) explicitly is _really_ needed.
    rpmbuild detects perl module based dependency automatically and adds those
    dependency to binary rpm.
    Actually if you try $ rpm -qp --requires clamtk-XXXXX.noarch.rpm", you will
    see many "perl(foo)" dependency.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.