[Bug 539983] Review Request: qjson - qt-based library that maps JSON data to QVariant object

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=539983





--- Comment #11 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com>  2009-12-08 05:13:50 EDT ---
Thanks for the update. We are getting there.The SRPM link above is broken but I
regenerated it from the SPEC file

* Please don't just use the summary here
   %description devel
   %{summary}.
You can use something like
   The %{name}-devel package contains libraries and header files for developing
   applications that use %{name}.

* These need to be in one line each
   LD_PRELOAD=%{_target_platform}/%{_lib}/libqjson.so
           %{_target_platform}/tests/testparser
   LD_PRELOAD=%{_target_platform}/%{_lib}/libqjson.so
           %{_target_platform}/tests/testserializer

so just add a \ at the end of the first lines.

* This issue still needs to be addressed:

> > - Where can I find an example to properly add FindQJSON.cmake as a requirment?
> >   Or better yet and quicker if you could detail the correct line.
> > 
> 
> I don't know exactly. You might want to do some research. However, I see that
> cmake package put a lot of modules into /usr/share/cmake/Modules/

I found that you can pass this flag to cmake
   -DCMAKE_MODULES_INSTALL_DIR=%{_datadir}/cmake/Modules/
to make it install the cmake module to the correct location. Note that you will
need to update the %files section accordingly.

* I fixed the \ issue myself to build the package otherwise it will fail to
build. The new package has the rpmlints:
   - qjson.x86_64: E: description-line-too-long JSON is a lightweight 
     data-interchange format. It can represents integer, real number, string,

   Please make the description fit 80 columns.

   - qjson.x86_64: W: incoherent-version-in-changelog 0.6.3-3 ['0.6.3-4.fc12', 
     '0.6.3-4']
   - qjson-devel.x86_64: W: summary-not-capitalized qjson Development Files

   These can be fixed easily

   - qjson.x86_64: W: spurious-executable-perm /usr/share/doc/qjson-0.6.3/html
     /installdox
   - qjson.x86_64: W: doc-file-dependency /usr/share/doc/qjson-0.6.3/html
     /installdox /usr/bin/perl

   I don't think this installdox file should be installed.

   - qjson-devel.x86_64: W: no-documentation

   There are multiple mistakes here:
      . The doxygen documentation you built normally belongs to the devel 
        package. It is supposed to be API documentation.
      . The doxygen documentation is not built properly. Check the generated
        index.html file. It is blank. You need the build the doxygen 
        documentation that is inside the doc/ directory.

Please make a test build in mock and check for rpmlints before you do the next
update.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.